This repository was archived by the owner on May 29, 2018. It is now read-only.
#16 Remove hardcoded dependency on node#19
Open
xizhao wants to merge 131 commits intosourcegraph:masterfrom
Open
#16 Remove hardcoded dependency on node#19xizhao wants to merge 131 commits intosourcegraph:masterfrom
xizhao wants to merge 131 commits intosourcegraph:masterfrom
Conversation
…inaries/compilation steps
Add some comments
handle module.parent
Member
There was a problem hiding this comment.
Will this make it so srclib-javascript will be unable to resolve the node standard lib to the repository URL? We eventually want to move away from repository URLs, but in the meantime, they are the standard way to identify repositories and resolve dependencies.
Author
There was a problem hiding this comment.
But we don't know it's node. An NPM package doesn't necessarily need node to run (it could be a frontend package, or not even javascript!)
And we don't know if it's node, iojs, etc...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.