Add support for excluded sdks#196
Merged
polac24 merged 18 commits intospotify:masterfrom Apr 11, 2023
Merged
Conversation
acbdev
approved these changes
Apr 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add an extra feature (still in the experimental phase) to exclude XCRemoteCache in some SDKs.
e.g. to disable XCRemoteCache for watchOS, a developer can either
--sdks-exclude "watchos*, watchsimulator*"to thexcprepare integratecommand or'exclude_sdks_configurations' => ["watchos*", "watchsimulator*"]to thexcremotecacheconfiguration in PodfileImplementation
This PR includes:
pre_buildwith build settingXCRC_DISABLED = YES. This ensures the rebuild script will not unnecessarily download an artifact (if a matching one exists on a remote server) which will not be used. Same for post_build (not not unnecessary upload artifacts) and marking (to not mark artifacts are available).--sdks-excludeparam to the CLI integration, which (in the project integration) overrides all XCRC-related params to "" for all SDK configurations listed in an argumentexclude_sdks_configurationsconfiguration.