Reset cflags and swiftflags on each cocoapods integration#197
Merged
polac24 merged 2 commits intospotify:masterfrom Apr 12, 2023
Merged
Reset cflags and swiftflags on each cocoapods integration#197polac24 merged 2 commits intospotify:masterfrom
polac24 merged 2 commits intospotify:masterfrom
Conversation
aleksandergrzyb
approved these changes
Apr 11, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #196, reported here. I made a silly mistake and introduced
reset_build_settingmethod never used is, while the intention was to call it instead that method instead ofadd_build_setting.Rationale
add_build_settingis a method that 1) adds the "main" build setting to all configurations (e.g.MY_VALIE=12and 2) overrides that with an empty value for all sdks that should be excluded (e.g.MY_VALUE[sdk=iphone*]=).Later, if you enable back previously excluded sdk (by deleting it from a list in a Podfile), the plugin doesn't remove the previously added override from step 2.
The updated flow:
MY_VALUE=123) and "overrides" (e.g.MY_VALUE[sdk=iphonesimulator*]=44)