[Cocoapods] Ensure the source build phase exist before enabling xcrc#218
Merged
polac24 merged 4 commits intospotify:masterfrom Aug 1, 2023
Merged
[Cocoapods] Ensure the source build phase exist before enabling xcrc#218polac24 merged 4 commits intospotify:masterfrom
polac24 merged 4 commits intospotify:masterfrom
Conversation
aleksandergrzyb
approved these changes
Aug 1, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of calling
Xcodeproj'ssource_build_phase, which creates a phase if it doesn't exist, try to find it manually.https://github.com/CocoaPods/Xcodeproj/blob/2ce68b60856c4680c2b3cd7aa5b221529120c7c4/lib/xcodeproj/project/object/native_target.rb#L615-L621
There will be no warnings, as having a "side" target that doesn't compile anything is completely legit and it is expected that XCRemoteCache just ignores it.
Fixes #217