Skip to content

[Cocoapods] Ensure the source build phase exist before enabling xcrc #218

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
polac24 merged 4 commits into from
Aug 1, 2023
Merged

[Cocoapods] Ensure the source build phase exist before enabling xcrc #218

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8955cb2
Bail out if source build phase phase doesnt exist
polac24 Jul 30, 2023
b048393
Define module of the source phase
polac24 Jul 30, 2023
2c23632
fix module
polac24 Jul 30, 2023
be87c37
Bump version
polac24 Jul 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions cocoapods-plugin/lib/cocoapods-xcremotecache/command/hooks.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -409,6 +409,11 @@ def self.save_lldbinit_rewrite(user_proj_directory,fake_src_root)
File.write(LLDB_INIT_PATH, lldbinit_lines.join("\n"), mode: "w")
end

# Contrary to AbstractTarget.source_build_phase, it only finds a build phase, without creating one if it doesn't exist
def self.find_source_build_phase(target)
target.build_phases.find { |bp| bp.class == Xcodeproj::Project::Object::PBXSourcesBuildPhase }
end

Pod::HooksManager.register('cocoapods-xcremotecache', :pre_install) do |installer_context|
# The main responsibility of that hook is forcing Pods regeneration when XCRemoteCache is enabled for the first time
# In the post_install hook, this plugin adds extra build settings and steps to all Pods targets, but only when XCRemoteCache
Expand Down Expand Up @@ -520,6 +525,8 @@ def self.save_lldbinit_rewrite(user_proj_directory,fake_src_root)
# Attach XCRemoteCache to Pods targets
# Enable only for native targets which can have compilation steps
installer_context.pods_project.native_targets.each do |target|
# Ensure the PBXSourcesBuildPhase exists as the flow would unnecessary create an empty source build phase otherwise
next if find_source_build_phase(target).nil?
next if target.source_build_phase.files_references.empty?
next if target.name.start_with?("Pods-")
next if target.name.end_with?("Tests")
Expand Down
2 changes: 1 addition & 1 deletion cocoapods-plugin/lib/cocoapods-xcremotecache/gem_version.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,5 +13,5 @@
# limitations under the License.

module CocoapodsXcremotecache
VERSION = "0.0.17"
VERSION = "0.0.18"
end