Skip to content

Add missing crd defaults to 23.4#278

Merged
adwk67 merged 1 commit intorelease-23.4from
release-23.4.1-crd-default-fix
May 15, 2023
Merged

Add missing crd defaults to 23.4#278
adwk67 merged 1 commit intorelease-23.4from
release-23.4.1-crd-default-fix

Conversation

@maltesander
Copy link
Member

Description

cherry picked from commit 4308923

Description

Please add a description here. This will become the commit message of the merge request later.

Definition of Done Checklist

  • Not all of these items are applicable to all PRs, the author should update this template to only leave the boxes in that are relevant
  • Please make sure all these things are done and tick the boxes
# Author
- [ ] Changes are OpenShift compatible
- [ ] CRD changes approved
- [ ] Helm chart can be installed and deployed operator works
- [ ] Integration tests passed (for non trivial changes)
# Reviewer
- [ ] Code contains useful comments
- [ ] (Integration-)Test cases added
- [ ] Documentation added or updated
- [ ] Changelog updated
- [ ] Cargo.toml only contains references to git tags (not specific commits or branches)
# Acceptance
- [ ] Feature Tracker has been updated
- [ ] Proper release label has been added

Once the review is done, comment bors r+ (or bors merge) to merge. Further information

# Description

Due to breaking changes in with the clusterConfig the CRD replace still works but the operator throws an error:
```
2023-05-12T08:51:04.696282Z ERROR stackable_operator::logging::controller: Failed to reconcile object controller.name="airflowcluster.airflow.stackable.tech" error=event queue error error.sources=[fa
iled to perform initial object list: Error deserializing response, Error deserializing response, missing field `credentialsSecret` at line 1 column 5264]
```
This will be gone when applying a new correct CR.

Co-authored-by: Malte Sander <[email protected]>

(cherry picked from commit 4308923)
@maltesander maltesander requested review from a team and adwk67 May 12, 2023 15:32
@maltesander maltesander self-assigned this May 12, 2023
Copy link
Member

@adwk67 adwk67 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM: tested with tilt vs. openshift (LDAP tests failed but that is because the fix is not in the release branch).

@adwk67
Copy link
Member

adwk67 commented May 15, 2023

bors merge

bors bot pushed a commit that referenced this pull request May 15, 2023
# Description

cherry picked from commit 4308923

# Description

*Please add a description here. This will become the commit message of the merge request later.*



Co-authored-by: Malte Sander <[email protected]>
@bors
Copy link

bors bot commented May 15, 2023

Build failed:

@adwk67 adwk67 merged commit 19c7a52 into release-23.4 May 15, 2023
@adwk67 adwk67 deleted the release-23.4.1-crd-default-fix branch May 15, 2023 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants