Add hbase-operator-tools to the HBase image#497
Merged
siegfriedweber merged 5 commits intomainfrom Nov 8, 2023
Merged
Conversation
Member
|
I'm building it now, it looks good in principle but has one problem that will be hard to overcome: HBase Operator Tools builds against Hadoop 2 I believe but to fix that would be rather annoying. If it works (did you test that @siegfriedweber?) I'm fine with it for now as we'll get a fix for this automatically when we upgrade to HBase 2.5++ |
Member
Author
|
I tested HBCK2 with version=1.2.0
# Schedule ServerCrashProcedure (SCP) for the given RegionServers
/stackable/hbase/bin/hbase hbck \
-j /stackable/hbase-operator-tools/hbase-hbck2/hbase-hbck2-$version.jar \
scheduleRecoveries $regionservers
# Schedule ServerCrashProcedure (SCP) for RegionServers that are reported as unknown
/stackable/hbase/bin/hbase hbck \
-j /stackable/hbase-operator-tools/hbase-hbck2/hbase-hbck2-$version.jar \
recoverUnknown |
lfrancke
reviewed
Nov 8, 2023
Member
lfrancke
left a comment
There was a problem hiding this comment.
Three things:
- One change request: Add the license to hbase/licenses/
- A suggestion but I'm fine merging it without: Add a shell script wrapper
hbck2that does the necessary call tohbasewith all the stuff wired up and put that shell in the PATH - A suggestion: Should we add a note in the docs about this tool being included?
Member
Author
added in 15de8ea
added in 012da89
added in stackabletech/hbase-operator#416 |
lfrancke
requested changes
Nov 8, 2023
Member
lfrancke
left a comment
There was a problem hiding this comment.
Minor thing, otherwise looks good. I built and tested it, thank you!
lfrancke
approved these changes
Nov 8, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add hbase-operator-tools to the HBase image
Definition of Done Checklist