Document the hbase-operator-tools contained in the HBase image#416
Merged
siegfriedweber merged 2 commits intomainfrom Nov 8, 2023
Merged
Document the hbase-operator-tools contained in the HBase image#416siegfriedweber merged 2 commits intomainfrom
siegfriedweber merged 2 commits intomainfrom
Conversation
lfrancke
approved these changes
Nov 8, 2023
| spec: | ||
| containers: | ||
| - name: hbck2 | ||
| image: docker.stackable.tech/stackable/hbase:2.4.17-stackable23.11.0 |
Member
There was a problem hiding this comment.
We can merge it as is, this is a comment for @fhennig when he is back:
Do we have any way of/do we do anything to update those kinds of hardcoded version references on a new release?
Contributor
There was a problem hiding this comment.
There actually is a way, it could be put into a templating variable and that gets updated on a release:
https://github.com/stackabletech/hbase-operator/blob/main/docs/templating_vars.yaml
release script snippet: https://github.com/stackabletech/stackable-utils/blob/main/release/create-bugfix-tag.sh#L145
I've made a note of it to use templating for this PR here
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Document the hbase-operator-tools contained in the HBase image
see stackabletech/docker-images#497