Conversation
Contributor
Author
|
This change is part of the following stack: Change managed by git-spice. |
This was referenced Mar 4, 2025
5 tasks
Contributor
|
Images are ready for the commit at c8b566d. To use with deploy scripts, first |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #14489 +/- ##
==========================================
- Coverage 49.17% 48.89% -0.29%
==========================================
Files 2532 2547 +15
Lines 185508 186867 +1359
==========================================
+ Hits 91223 91367 +144
- Misses 87047 88269 +1222
+ Partials 7238 7231 -7
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
8f7afb7 to
a36833b
Compare
msugakov
reviewed
Mar 24, 2025
4 tasks
This reverts commit 4259821. Signed-off-by: Tomasz Janiszewski <[email protected]>
msugakov
reviewed
Apr 1, 2025
Contributor
msugakov
left a comment
There was a problem hiding this comment.
I unchecked this box for you
because I see the CI is running currently.
Please ping me for re-review once you checked the CI status. Thank you.
Contributor
Author
|
/retest |
msugakov
approved these changes
Apr 8, 2025
9 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
lz4 and bzip2 were added to support rocksdb since we do not use it anymore we can remove them.
Testing
Automated testing
How I validated my change
CI