Skip to content

build: Remove rocksdb dependencies from Konflux builder stage#14728

Merged
msugakov merged 2 commits intomasterfrom
misha/remove-rocksdb-stuff-from-konflux
Apr 4, 2025
Merged

build: Remove rocksdb dependencies from Konflux builder stage#14728
msugakov merged 2 commits intomasterfrom
misha/remove-rocksdb-stuff-from-konflux

Conversation

@msugakov
Copy link
Copy Markdown
Contributor

@msugakov msugakov commented Mar 24, 2025 •
edited
Loading

Description

Triggered by #14489

User-facing documentation

  • CHANGELOG is updated OR update is not needed
  • documentation PR is created and is linked above OR is not needed

Testing and quality

  • the change is production ready: the change is GA or otherwise the functionality is gated by a feature flag
  • CI results are inspected

Automated testing

No change.

How I validated my change

Only Konflux build CI. If it passes, we're good.

@github-actions github-actions bot added area/helm konflux-build Run Konflux in PR. Push commit to trigger it. labels Mar 24, 2025
@msugakov msugakov mentioned this pull request Mar 24, 2025
Merged
5 tasks
@msugakov msugakov changed the title Remove rocksdb build dependencies from Konflux builder stage build: Remove rocksdb dependencies from Konflux builder stage Mar 24, 2025
@rhacs-bot
Copy link
Copy Markdown
Contributor

rhacs-bot commented Mar 24, 2025 •
edited
Loading

Images are ready for the commit at 506b989.

To use with deploy scripts, first export MAIN_IMAGE_TAG=4.8.x-388-g506b9896e0.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 24, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 49.01%. Comparing base (abf4ab5) to head (506b989).
Report is 3 commits behind head on master.

Additional details and impacted files 
@@           Coverage Diff           @@
##           master   #14728   +/-   ##
=======================================
  Coverage   49.01%   49.01%           
=======================================
  Files        2547     2547           
  Lines      186947   186947           
=======================================
+ Hits        91627    91628    +1     
+ Misses      88069    88068    -1     
  Partials     7251     7251
Flag Coverage Δ
go-unit-tests 49.01% <ø> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@msugakov msugakov added backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 labels Mar 25, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Mar 25, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Mar 25, 2025
@msugakov
Copy link
Copy Markdown
Contributor Author

msugakov commented Mar 25, 2025

Main builds succeeded on all arches except for ppc64le where there's currently an outage.
Good to open for review now.

@msugakov msugakov marked this pull request as ready for review March 25, 2025 18:16
@msugakov msugakov requested a review from a team as a code owner March 25, 2025 18:16
@msugakov msugakov requested review from janisz and tommartensen March 25, 2025 18:16
@stackrox stackrox deleted a comment from openshift-ci bot Mar 27, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Mar 27, 2025
@msugakov
Copy link
Copy Markdown
Contributor Author

msugakov commented Mar 28, 2025

/retest main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Mar 28, 2025
@msugakov
Copy link
Copy Markdown
Contributor Author

msugakov commented Mar 28, 2025

/retest main-on-push

1 similar comment
@msugakov
Copy link
Copy Markdown
Contributor Author

msugakov commented Mar 28, 2025

/retest main-on-push

@stackrox stackrox deleted a comment from openshift-ci bot Mar 28, 2025
@stackrox stackrox deleted a comment from openshift-ci bot Mar 28, 2025
msugakov added 2 commits April 4, 2025 14:11
@msugakov
Remove rocksdb build dependencies from Konflux builder stage
3669205
@msugakov
Restore jq and separate Go build and swagger steps
506b989 
There's a build error without `jq`

```
xargs: jq: No such file or directory
subprocess exited with status 127
subprocess exited with status 127
Error: building at STEP "RUN . /cachi2/cachi2.env &&     make main-build-nodeps cli-build &&     mkdir -p image/rhel/docs/api/v1 &&     ./scripts/mergeswag.sh 1 generated/api/v1 central/docs/api_custom_routes >image/rhel/docs/api/v1/swagger.json &&     mkdir -p image/rhel/docs/api/v2 &&     ./scripts/mergeswag.sh 2 generated/api/v2 >image/rhel/docs/api/v2/swagger.json": exit status 127
```

https://console.redhat.com/application-pipeline/workspaces/rh-acs/applications/acs/pipelineruns/main-on-push-8rzb6

Supposedly, that's from Swagger generation scripts therefore I
separate them to have failures more isolated in the future.
@msugakov msugakov force-pushed the misha/remove-rocksdb-stuff-from-konflux branch from 943fce3 to 506b989 Compare April 4, 2025 12:11
@openshift-ci
Copy link
Copy Markdown

openshift-ci bot commented Apr 4, 2025

@msugakov: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
ci/prow/ocp-4-12-qa-e2e-tests 506b989 link false /test ocp-4-12-qa-e2e-tests
ci/prow/ocp-4-12-operator-e2e-tests 506b989 link false /test ocp-4-12-operator-e2e-tests
ci/prow/gke-upgrade-tests 506b989 link false /test gke-upgrade-tests

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@msugakov
Copy link
Copy Markdown
Contributor Author

msugakov commented Apr 4, 2025

Ignoring regular e2e test errors because they don't test Konflux images. Merging.

@msugakov msugakov merged commit 20cb274 into master Apr 4, 2025
107 of 118 checks passed
@msugakov msugakov deleted the misha/remove-rocksdb-stuff-from-konflux branch April 4, 2025 18:10
ajheflin pushed a commit that referenced this pull request Jun 24, 2025
@msugakov @ajheflin
build: Remove rocksdb dependencies from Konflux builder stage (#14728)
22e4a9e 
 Conflicts:
	image/rhel/konflux.Dockerfile
msugakov added a commit that referenced this pull request Jun 27, 2025
@msugakov
build: Remove rocksdb dependencies from Konflux builder stage (#14728)
e718e59 
 Conflicts:
	image/rhel/konflux.Dockerfile
ajheflin pushed a commit that referenced this pull request Jun 27, 2025
@msugakov @ajheflin
build: Remove rocksdb dependencies from Konflux builder stage (#14728)
a565b3a 
Conflicts:
	image/rhel/konflux.Dockerfile
msugakov added a commit that referenced this pull request Jun 27, 2025
@msugakov
build: Remove rocksdb dependencies from Konflux builder stage (#14728)
3beee38 
 Conflicts:
	image/rhel/konflux.Dockerfile
msugakov added a commit that referenced this pull request Jul 1, 2025
@msugakov
build: Remove rocksdb dependencies from Konflux builder stage (#14728)
97c2254 
 Conflicts:
	image/rhel/konflux.Dockerfile
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@janisz janisz janisz approved these changes

@tommartensen tommartensen tommartensen approved these changes

Assignees

No one assigned

Labels

area/helm backport-for-4.6-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1730134914487439 backport-for-4.7-konflux-release https://redhat-internal.slack.com/archives/C05TS9N0S7L/p1739787699448879 konflux-build Run Konflux in PR. Push commit to trigger it.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@msugakov @rhacs-bot @janisz @tommartensen