Conversation
…ighten the lists of functions arguments. + Added cabling_constants.hh + cabling_functions.hh
…i. This was bound to have disks and their cabling entirely identical on both -Z and +Z sides. Now, Phi-nonants boundaries are ligned-up all along Z. As a result, disks will be different whetehr they are placed on (-Z) and (+Z) sides.
… for Phi = 0, so that disks are exactly identical oin both sides along a Z axis.
Add distributions of hits in global and local frames of reference
…ctive element, one should not select the Z > 0 volumes only (assuming eta >= 0). Indeed, the IP can be at Z < 0, hence volumes on (-Z) side can be hit.
…unt in track length section calculation!
…red along a track!.
…ement::checkTrackHits has the following issues in devLite: some hits positions are wrongly computed and are actually not inside the inactive volume, hugely increasing the total crossed MB (and hence worsening the resolution). + Case of a tube or disk crossed in the non-trivial sense not always taken into account. Created new and fully debugged InactiveElement::checkTrackHits method (should be backported to devLitegit log).
…s region is a gaussian Gaus(0, 70). Though, the code was only taking into consideration the sensors such that sensor.maxZ() > 0.
…gion from -70 mm to 70 mm.
… Still addEfficiency issue to solve.
…) : now compiles :)
…, because the local resolution is assigned to it. It cannot be stored directly within the track, since a given module will be hit by several tracks, and we want the information at the module level!
…s) plot in OT material tab: was showing OT + IT result instead of OT result only. This is not really an issue in itself, but since there is a OT, IT, and Total material tabs, things should follow that logic.
…Simparms. Not finished yet
…fied directly in SimParms, instead of hardcoded in Analysis code. NB 1: rPhiErrorCollider has never been used for defining the origin of the track! And the analysis code is not adapted consequently. One assumes that the track is always on (Z) axis. NB 2: Would be more elegant to have a Shape of luminous region class, where one could specify the parameters of interest relevant for each supported distribution.
Important: Bug fixes affecting tracking resolution + Shape of luminous region for resolution studies
IMPORTANT: Bug fix in trigger efficiency results
Pattern reco studies: Switch from IP = (0,0,0) to uniform luminous region from -70 mm to 70 mm.
Merge PR#332 from Zbynek: renaming HitNew -> Hit, TrackNew -> Track
Shape of luminous region directly specified in SimParms
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.