Skip to content

Merging dev_gabie into dev#412

Merged
alkemyst merged 626 commits intodevfrom
dev_gabie
Dec 12, 2017
Merged

Merging dev_gabie into dev#412
alkemyst merged 626 commits intodevfrom
dev_gabie

Conversation

@alkemyst
Copy link
Contributor

No description provided.

ghugo83 added 30 commits June 21, 2017 16:20
…ighten the lists of functions arguments. + Added cabling_constants.hh + cabling_functions.hh
…i. This was bound to have disks and their cabling entirely identical on both -Z and +Z sides. Now, Phi-nonants boundaries are ligned-up all along Z. As a result, disks will be different whetehr they are placed on (-Z) and (+Z) sides.
… for Phi = 0, so that disks are exactly identical oin both sides along a Z axis.
ghugo83 and others added 28 commits November 22, 2017 15:17
Add distributions of hits in global and local frames of reference
…ctive element, one should not select the Z > 0 volumes only (assuming eta >= 0). Indeed, the IP can be at Z < 0, hence volumes on (-Z) side can be hit.
…ement::checkTrackHits has the following issues in devLite: some hits positions are wrongly computed and are actually not inside the inactive volume, hugely increasing the total crossed MB (and hence worsening the resolution). + Case of a tube or disk crossed in the non-trivial sense not always taken into account. Created new and fully debugged InactiveElement::checkTrackHits method (should be backported to devLitegit log).
…s region is a gaussian Gaus(0, 70). Though, the code was only taking into consideration the sensors such that sensor.maxZ() > 0.
…, because the local resolution is assigned to it. It cannot be stored directly within the track, since a given module will be hit by several tracks, and we want the information at the module level!
…s) plot in OT material tab: was showing OT + IT result instead of OT result only. This is not really an issue in itself, but since there is a OT, IT, and Total material tabs, things should follow that logic.
…fied directly in SimParms, instead of hardcoded in Analysis code. NB 1: rPhiErrorCollider has never been used for defining the origin of the track! And the analysis code is not adapted consequently. One assumes that the track is always on (Z) axis. NB 2: Would be more elegant to have a Shape of luminous region class, where one could specify the parameters of interest relevant for each supported distribution.
Important: Bug fixes affecting tracking resolution + Shape of luminous region for resolution studies
IMPORTANT: Bug fix in trigger efficiency results
Pattern reco studies: Switch from IP = (0,0,0) to uniform luminous region from -70 mm to 70 mm.
Merge PR#332 from Zbynek: renaming HitNew -> Hit, TrackNew -> Track
Shape of luminous region directly specified in SimParms
@alkemyst alkemyst merged commit 14b4fe8 into dev Dec 12, 2017
@alkemyst alkemyst deleted the dev_gabie branch December 12, 2017 14:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants