Conversation
| , public RObjectMethods<T> | ||
| : public NamesProxyPolicy<ListOf<T>> | ||
| , public AttributeProxyPolicy<ListOf<T>> | ||
| , public RObjectMethods<ListOf<T>> |
Member
There was a problem hiding this comment.
I am a bit surprised how this suddenly becomes recursive (in the usual 'curious' manner) but does not require code changes. That seems like a free lunch. I am probably missing something.
Contributor
There was a problem hiding this comment.
The intention here was to make use of CRTP; I think I erred in leaving out the ListOf in the inheritance.
| parent.set__(new_vec); // #nocov end | ||
| } | ||
|
|
||
| Rf_namesgets(parent, Shield<SEXP>(x)); |
Member
There was a problem hiding this comment.
That looks like a great simplification we can do now / could not do then.
eddelbuettel
approved these changes
Mar 27, 2026
Member
eddelbuettel
left a comment
There was a problem hiding this comment.
LGTM -- two comments inline.
Member
Author
|
Let's wait for a revdep also with this one just in case. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1463.
Checklist
R CMD checkstill passes all tests