This repository was archived by the owner on Dec 15, 2022. It is now read-only.
Lowercase hex in str#215
Merged
winstliu merged 3 commits intoatom:masterfrom Oct 21, 2017
kbrose:lowercase-hex-in-str
Merged
Conversation
Contributor
|
Thanks, looks good. I'll merge once you revert the unrelated auto-indent changes. |
Contributor
Author
|
@50Wliu done. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the Change
Add lowercase letters to hex characters inside strings.
Alternate Designs
None
Benefits
Proper highlighting of lowercase hex letters such as
Possible Drawbacks
None..................?
Applicable Issues
#200
Stagnant PR accomplishing same thing w/o tests: #201