Skip to content

V4 support beta#418

Open
liquid-8 wants to merge 77 commits intomasterfrom
dev/v4-fin
Open

V4 support beta#418
liquid-8 wants to merge 77 commits intomasterfrom
dev/v4-fin

Conversation

@liquid-8
Copy link
Member

@liquid-8 liquid-8 commented Dec 25, 2025

Basic functionality, like price fetching, quoting, and making simple swaps etc

@liquid-8 liquid-8 linked an issue Jan 5, 2026 that may be closed by this pull request
Uniswap v4 support #337
Open
@liquid-8
Add files via upload
74e72b4 
Pool manager contract ABI
@liquid-8
Delete uniswap/configs/evmuniV4_permit2.ini
e33e9d2 
Deleted due to naming fix
@liquid-8
Delete uniswap/configs/evmuniV4_chains.ini
f7d8274 
Deleted due to naming fix
@liquid-8
Delete uniswap/configs/evmuniV4_quoter.ini
d7387a2 
Deleted due to naming fix
@liquid-8
Delete uniswap/configs/evmuniV4_router.ini
b21f2ee 
Deleted due to naming fix
@liquid-8
Delete uniswap/configs/evmuniV4_stateview.ini
e097c4c 
Deleted due to naming fix
@liquid-8
Add files via upload
3a55c6a 
Naming fix
@liquid-8
Add files via upload
60a08b8 
Liquidity pools list management class added, UniswapV4 improvements.
ErikBjare
ErikBjare approved these changes Jan 16, 2026
View reviewed changes
Copy link
Member

@ErikBjare ErikBjare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally approved. Haven't checked why CI is failing yet.

Could use some auto-formatting by ruff.

@ErikBjare
Copy link
Member

ErikBjare commented Jan 16, 2026

Ah, I see CI is failing due to outdated actions. I think we can merge this and address the outdated CI and any CI issues related to this PR in follow-up.

ErikBjare
ErikBjare reviewed Jan 16, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Jan 16, 2026
View reviewed changes
liquid-8 and others added 2 commits March 17, 2026 05:42
@liquid-8
fixes
cc8c5f1
@liquid-8
Merge pull request #426 from liquid-8/uniswap4_RC
e3287ec 
PositionManager full support; PoolManager full support; contracts-related methods naming improvements.
@ErikBjare
Copy link
Member

ErikBjare commented Mar 17, 2026

@greptileai review

greptile-apps[bot]
greptile-apps bot reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
ErikBjare
ErikBjare reviewed Mar 17, 2026
View reviewed changes
Copy link
Member

@ErikBjare ErikBjare left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, had a few comments that would clean it up.

I guess now is a good time to write some basic tests for it. I should look into fixing the test CI...

@liquid-8
Copy link
Member Author

liquid-8 commented Mar 17, 2026

Looks good, had a few comments that would clean it up.

I guess now is a good time to write some basic tests for it. I should look into fixing the test CI...

Suggestions are fine. I was going to merge this class with the main one eventually, but even now, it is just too big. Thanks for the review, will fix and proceed.

@liquid-8
Copy link
Member Author

liquid-8 commented Mar 18, 2026

Looks good, had a few comments that would clean it up.
I guess now is a good time to write some basic tests for it. I should look into fixing the test CI...

Suggestions are fine. I was going to merge this class with the main one eventually, but even now, it is just too big. Thanks for the review, will fix and proceed.

And it's done.

liquid-8 and others added 9 commits March 19, 2026 21:29
@liquid-8
poetry.lock fix
149aba1
@liquid-8
Merge pull request #428 from liquid-8/uniswap4_RC
e3c3226 
poetry.lock fix
@liquid-8
v4 test prototype
0228e5d
@liquid-8 @greptile-apps
Update uniswap/uniswap4.py
9bf1d9b 
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@liquid-8 @greptile-apps
Update tests/v4tests.py
43c7927 
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
@liquid-8
fix
94da45f
@liquid-8
Merge branch 'uniswap4_RC' of https://github.com/liquid-8/uniswap-python
b070366 
 into uniswap4_RC
@liquid-8
Merge pull request #429 from liquid-8/uniswap4_RC
4d08576 
v4 test prototype
@liquid-8
tech fix
4c0eb28
@TimeToBuildBob TimeToBuildBob mentioned this pull request Mar 26, 2026
Merged
2 tasks
@TimeToBuildBob
fix(ci): replace rate-limited Infura with public RPC (#431)
b2eb3a0 
* fix(ci): replace rate-limited Infura with public RPC and fix type errors

- Switch PROVIDER_MAINNET fallback from Infura to ethereum.publicnode.com
  (Infura public key was hitting "Too Many Requests" rate limits)
- Add dev/v4 and dev/v4-fin branches to CI triggers
- Fix mypy errors: use str() for bytes fallback in token name/symbol
  decode, add type: ignore for web3 get_logs attribute

Co-authored-by: Bob <[email protected]>

* fix(ci): switch Arbitrum RPC and resolve mypy warning
@TimeToBuildBob
fix(ci): stop push runs from preferring stale mainnet secret (#432)
ade1cf8
@codecov
Copy link

codecov bot commented Mar 27, 2026 •
edited
Loading

Codecov Report

❌ Patch coverage is 25.19582% with 573 lines in your changes missing coverage. Please review.
✅ Project coverage is 58.83%. Comparing base (f5a9e86) to head (ade1cf8).

Files with missing lines Patch % Lines
uniswap/uniswap4.py 21.46% 483 Missing ⚠️
uniswap/util.py 11.76% 90 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##           master     #418      +/-   ##
==========================================
- Coverage   60.52%   58.83%   -1.69%     
==========================================
  Files          11       12       +1     
  Lines        1074     1834     +760     
==========================================
+ Hits          650     1079     +429     
- Misses        424      755     +331

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ErikBjare ErikBjare ErikBjare requested changes

+1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@liquid-8 liquid-8

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Uniswap v4 support

3 participants

@liquid-8 @ErikBjare @TimeToBuildBob