TST: Restore some tolerances for some arch/platform-specific failures#31343
Open
QuLogic wants to merge 2 commits intomatplotlib:text-overhaulfrom
Open
TST: Restore some tolerances for some arch/platform-specific failures#31343QuLogic wants to merge 2 commits intomatplotlib:text-overhaulfrom
QuLogic wants to merge 2 commits intomatplotlib:text-overhaulfrom
Conversation
The tolerance on these was increased in various PRs, with notes to reduce/remove them, so they were removed in matplotlib#30184, but should have been reverted to a smaller value. - `test_floating_axes.py::test_curvelinear4[png]` fails on macOS - `test_grid_helper_curvelinear.py::test_axis_direction[png]` fails on ARM and macOS - `test_grid_helper_curvelinear.py::test_polar_box[png]` fails on Windows, ARM, and macOS These fail on macOS; there's a tolerance on them already, they fail by just a small amount, so increase it. - `test_patheffects.py::test_collection[png]` - `test_axes3d.py::test_scale3d_artists_log[png]`
9f6c9e9 to
8a451fb
Compare
Since Helvetica may or may not be installed, the line height measurement may differ between systems, so multi-line text as in this test may change. This test doesn't care about line heights, but is about using PDF's "standard" fonts, so we'll just manually place the lines. Unfortunately, since text placement still depends on the exact split of ascent/descent, we still need to add some increased tolerance here. This will be fixed when all backends correctly apply font metrics for line height, and PDF can arrange to use our bundled core 14 font metrics for that.
Member
Author
|
OK, this is now passing. The failure in |
Member
Author
|
OK, it does require a bit of internal trickery, but instead of the last commit, we can instead do #31371. |
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
test_polar_boxfails on Windows, ARM, and macOS.test_axis_directionfails on ARM and macOS.There are still a few more to fix, but just checking that these are fine.
AI Disclosure
None
PR checklist