ps/pdf: Override font height metrics to support AFM files#31371
Open
QuLogic wants to merge 1 commit intomatplotlib:text-overhaulfrom
Open
ps/pdf: Override font height metrics to support AFM files#31371QuLogic wants to merge 1 commit intomatplotlib:text-overhaulfrom
QuLogic wants to merge 1 commit intomatplotlib:text-overhaulfrom
Conversation
When outputting files using the "core 14 fonts" (e.g., `rcParams['pdf.use14corefonts'] = True`), text will be measured using our internal AFM files instead of any external files. While we don't have a full API decided for how to pass full `Text` objects through backends, add in a small internal helper to allow the PS/PDF backends to override font height metrics with the AFM files.
1 task
Member
Author
|
Test failures should just be from #31343. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR summary
When outputting files using the "core 14 fonts" (e.g.,
rcParams['pdf.use14corefonts'] = True), text will be measured using our internal AFM files instead of any external files.While we don't have a full API decided for how to pass full
Textobjects through backends, add in a small internal helper to allow the PS/PDF backends to override font height metrics with the AFM files.Note, because there is still some small difference in how we calculated line spacing, there is some small difference in the result from before. But it no longer changes results depending on whether Helvetica is installed globally.
AI Disclosure
None
PR checklist