feat: enable newly ported rules in typescript recommended config#599
Merged
chenjiahan merged 2 commits intomainfrom Apr 7, 2026
Merged
feat: enable newly ported rules in typescript recommended config#599chenjiahan merged 2 commits intomainfrom
chenjiahan merged 2 commits intomainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates the TypeScript configuration in packages/rslint/src/configs/typescript.ts by enabling several ESLint rules that were previously commented out as unimplemented. These include rules such as no-func-assign, no-var, prefer-const, and use-isnan, which are now active in the configuration. I have no feedback to provide.
2 tasks
Enable 16 rules that have been ported and were previously commented out: - Turn off rules handled by TypeScript: no-func-assign, no-import-assign, no-obj-calls, no-setter-return, no-this-before-super, no-undef, no-unsafe-negation - Enable TS-beneficial rules: no-var, prefer-const, prefer-rest-params - Enable remaining eslint:recommended rules: no-empty-character-class, no-ex-assign, no-global-assign, no-invalid-regexp, no-self-assign, use-isnan
93b0417 to
35caa5b
Compare
The newly enabled prefer-const rule catches 4 violations in the rslint codebase. Override to warn severity in rslint.config.ts to avoid blocking CI while the violations are addressed separately.
chenjiahan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Enable 16 rules in the TypeScript
recommendedconfig that were previously commented out as "not implemented" and have since been ported:Rules turned off (handled by TypeScript, per official eslint-recommended override):
no-func-assignno-import-assignno-obj-callsno-setter-returnno-this-before-superno-undefno-unsafe-negationTS-beneficial rules enabled:
no-varprefer-constprefer-rest-paramsRemaining eslint:recommended rules (not turned off by TS):
no-empty-character-classno-ex-assignno-global-assignno-invalid-regexpno-self-assignuse-isnanAll rule names and values are aligned with the official
typescript-eslintv8.57.0eslint-recommendedoverride and@eslint/jsv9.32.0eslint:recommended.Related Links
Checklist