fix: add nil TypeChecker guard in no-ex-assign rule#600
Merged
Conversation
collectCatchBindingNamesAndSymbols accessed ctx.TypeChecker without a nil check, causing a panic on files where no type checker is available (e.g. TS files not covered by any project config).
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces nil checks for ctx.TypeChecker in the collectCatchBindingNamesAndSymbols function within internal/rules/no_ex_assign/no_ex_assign.go. These changes prevent potential nil pointer dereferences when attempting to retrieve symbols at specific locations. I have no feedback to provide.
2 tasks
chenjiahan
approved these changes
Apr 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
collectCatchBindingNamesAndSymbolsin theno-ex-assignrule accessedctx.TypeChecker.GetSymbolAtLocation()without a nil check, causing a panic on files where no type checker is available (e.g. TS files not covered by any project config in the self-lint).This fix adds nil guards at the two call sites (lines 24 and 39), consistent with how other core ESLint rules (no-func-assign, no-import-assign, no-setter-return, etc.) handle the absent checker.
Related Links
Checklist