Skip to content

Move Gazebo plugin configuration to server.config#31

Closed
E-Krantz wants to merge 1 commit intomainfrom
dev-gz_server_config
Closed

Move Gazebo plugin configuration to server.config#31
E-Krantz wants to merge 1 commit intomainfrom
dev-gz_server_config

Conversation

@E-Krantz
Copy link
Copy Markdown

This PR updates PX4-Space to align with recent changes in the original PX4-Autopilot repository, where Gazebo system plugin definitions are now managed centrally via a server.config file rather than embedded in each world SDF.

  • Adds src/modules/simulation/gz_bridge/server.config containing the required system plugin definitions.
  • Modifies src/modules/simulation/gz_bridge/gz_env.sh.in to set GZ_SIM_SERVER_CONFIG_PATH, ensuring Gazebo loads plugins from the version-controlled config.

This change keeps our workflow consistent with upstream PX4-Autopilot.

@E-Krantz E-Krantz requested a review from Pedro-Roque June 24, 2025 21:08
@E-Krantz E-Krantz self-assigned this Jun 24, 2025
@E-Krantz
Copy link
Copy Markdown
Author

Small note,

make px4_sitl

needs to be run once after pulling to update gz_env.sh in build/.

@LindavdSpaa
Copy link
Copy Markdown

This runs on my side, but it only adds the server.config, not the changes you requested in PR #30, the one Pedro reverted.

@E-Krantz
Copy link
Copy Markdown
Author

E-Krantz commented Jun 27, 2025

Yes. This one only fixes the missing plugins from PR #30.

Without PR #30, this one should not change any behaviour and can thus be safely merged with or without PR #30.

@Pedro-Roque
Copy link
Copy Markdown
Member

@E-Krantz can you add on this PR the changes from #30 so we can test it all together?

@E-Krantz
Copy link
Copy Markdown
Author

Okay. I will create a new PR with the changes of both PR #30 and PR #31 instead, then close those two.

@E-Krantz
Copy link
Copy Markdown
Author

@Pedro-Roque, moved to #33

@E-Krantz E-Krantz closed this Jul 3, 2025
@E-Krantz
Copy link
Copy Markdown
Author

E-Krantz commented Jul 3, 2025

Closed PR. Moved to #33

@Pedro-Roque Pedro-Roque deleted the dev-gz_server_config branch July 3, 2025 14:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants