fix: implement warning logs on non-owner invoking ServerRpc that requires ownership#627
Merged
mattwalsh-unity merged 2 commits intorelease/0.1.0from Mar 16, 2021
Merged
Conversation
wackoisgod
approved these changes
Mar 16, 2021
Contributor
wackoisgod
left a comment
There was a problem hiding this comment.
validated the generated code.
becksebenius-unity
approved these changes
Mar 16, 2021
Contributor
becksebenius-unity
left a comment
There was a problem hiding this comment.
This change looks good, although the fact that you're just now adding Debug_LogWarning_MethodRef makes me concerned that we might be missing other important warning cases
Contributor
|
I think that is likely true :P I think until we get better overall testing we are going to be in that state much of the time. |
| switch (methodInfo.Name) | ||
| { | ||
| case k_Debug_LogWarning: | ||
| if (methodInfo.GetParameters().Length == 1) Debug_LogWarning_MethodRef = moduleDefinition.ImportReference(methodInfo); |
Contributor
There was a problem hiding this comment.
Shouldn't this use MLAPIs networklog like pretty much everything else in our codebase?
Contributor
There was a problem hiding this comment.
I mean doesn't it just goto LogWarning anyway and just add a "[MLAPI]" prefix?
Contributor
There was a problem hiding this comment.
Yes but if it is a client logging the warning (which is the case here) then it will also send a network message to the server to display the log there as well. Since this method looks like something we might reuse later for other ILPP stuff we might want to get this right to have logging consistency? Not sure if it is really needed.
This was referenced Mar 16, 2021
0xFA11
added a commit
that referenced
this pull request
Mar 23, 2021
* fix: implement warning logs on non-owner invoking ServerRpc that requires ownership (#627) * add todo comments * fix: implement warning logs on non-owner invoking ServerRpc that requires ownership * fix: Correcting the profiler names for network vars to be appropriately named. Should address issue #605 (#632) * test: NetworkTickSystem test (#630) * test: NetworkTickSystem test * test: NetworkTickSystem test, removed unneeded code * fix: Fix object traversal assigning instanceIds to none scene objects (#629) * fix: Fix object traversal assigning instanceIds to none scene objects * comment added Co-authored-by: Matt Walsh <[email protected]> * fix: Correcting the profiler names for named messages vars to be appropriately named. Should address issue #604 (#634) * fix: prevent OnPerformanceTickData from sending data on null (#614) If something causes an exception it's possible that the profiler never allocates data. in these cases, there is no point in sending data outside of MLAPI * fix: use specified transport channel instead of hardcoded reliablerpc channel (#638) * docs: added release notes to changelog.md (#569) * Add release notes to changelog * docs: added release notes to changelog * Update com.unity.multiplayer.mlapi/CHANGELOG.md Co-authored-by: Luke Stampfli <[email protected]> * update per review for bitserializer and networkserializer * revised per feedback - API refactor * update remove bitserializer * renaming * Update com.unity.multiplayer.mlapi/CHANGELOG.md Co-authored-by: M. Fatih MAR <[email protected]> * Update com.unity.multiplayer.mlapi/CHANGELOG.md * Update com.unity.multiplayer.mlapi/CHANGELOG.md * added known issues and scene mgmt fix * revisions per review * profiler final - no more updates * format Co-authored-by: Luke Stampfli <[email protected]> Co-authored-by: Matt Walsh <[email protected]> Co-authored-by: M. Fatih MAR <[email protected]> * docs: Update repository/project docs (#636) - Mirror package readme.md in root readme.md - Add repo directory structure description - Remove contributing and code of conduct from package directory * docs: Add content for mlapi manual.md (#639) resolves #553 resolves MTT-534 * fix: Removed per-tick runtime allocations by reusing memory between ticks (#640) PerformanceDataManager reuses PerformanceTickData by resetting per-frame Replaces deferred linq query in PerformanceTickData loop. * fix: fixed network activity occurring outside the core update getting missed in the profiler (#641) Co-authored-by: Matt Walsh <[email protected]> * fix: Resolve an issue where 2019.4 would not properly run ILPP with a clean import (#645) * Add an dummy ILPP to force 2019.4 to proper compilation order * Turning on this test for 2019.4 * Hack -> Workaround rename Co-authored-by: Matt Walsh <[email protected]> Co-authored-by: Matt Walsh <[email protected]> * build: add Unity module dependencies explicitly (#648) Co-authored-by: kvassall-unity <[email protected]> Co-authored-by: Jeffrey Rainy <[email protected]> Co-authored-by: Albin Corén <[email protected]> Co-authored-by: Matt Walsh <[email protected]> Co-authored-by: Lori Krell <[email protected]> Co-authored-by: Luke Stampfli <[email protected]> Co-authored-by: Matt Walsh <[email protected]> Co-authored-by: Jesse Olmer <[email protected]> Co-authored-by: becksebenius-unity <[email protected]> Co-authored-by: Andrew Spiering <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixes #601