Fix muted color contrast and add cross-resource navigation#74
Merged
Conversation
From server detail, press v/g/N to jump to the Volumes, Security Groups, or Networks tab with the cursor positioned on the related resource. Pressing Esc returns to server detail. - Add NavigateToResourceMsg for tab switching with highlight context - Add SetHighlight (volumelist) and ScrollToNames (secgroupview, networklist) with race-safe re-apply on data load - Add returnToView field for back-navigation via Esc - Add [v]/[g]/[N] labels in server detail for discoverability - Update help overlay with new keybindings Partially addresses #73.
Show a short UUID (first 8 chars) in the volume list so users can match volumes to the UUIDs shown in server detail. The column has priority 2 and hides on narrow terminals alongside Device.
c8154b5 to
0e3b8c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ColorMutedfrom#586E75to#657B83, improving contrast ratio from ~3.2:1 to ~4.0:1 (WCAG AA). Replace two hardcoded hex values with theColorMutedvariable.v(volumes),g(security groups), orN(networks) to jump to the related tab with cursor positioned on the server's attached resource.Escreturns to server detail. Includes discoverable[v]/[g]/[N]labels and help text updates.Partially addresses #73 and #60.
Test plan
v→ cursor lands on the volume →Escreturns to server detailg→ sec group tab opens with matching group expanded →Escreturns to server detailN→ networks tab opens with matching network expanded →Escreturns to server detailv/g/Nare no-ops when server has no resources of that type?in server detail → new keybindings appear in help overlay