Conversation
puravdatta-sudo
approved these changes
Oct 20, 2021
Member
puravdatta-sudo
left a comment
There was a problem hiding this comment.
Looks good to merge, finding this in the docs is quite difficult. The "trajectory" tab should likely be called "trajectory following". currently it seems that it is part of the pure pursuit implementation.
Member
Author
Eventually, the PP implementation will be modified a good bit to work with FTCLib trajectories instead of ithe current nterpolation between waypoints, so that's not too far off. |
JIceberg
added a commit
that referenced
this pull request
Feb 21, 2022
* fix readme * fix: contributing guidelines outdated errors * update PR template * Add Upgraded Motor Groups (#164) * feat: upgraded motor groups * fix: add stop motor when button is released * fix: missing follower logic in set() * change x on L106 to motor to be more descriptive Co-authored-by: dansman805 <[email protected]> * change x on L113 to motor to be more descriptive Co-authored-by: dansman805 <[email protected]> * feat: verbose comments on flywheel sample * fix: change NotNull JB annotation to NonNull from androidx * fix: missing comment for clearing the bulk cache in sample Co-authored-by: Purav Datta <[email protected]> Co-authored-by: dansman805 <[email protected]> * add: new method to directly power mecanum drive wheels (#186) * Update Mecanum Sample (#187) * fix: mecanum sample to be readable and useful * add: drawings and descriptions throughout sample * fix: model of robot frame * feat: update SDK dependencies * fix: Bumped eocv to 1.5.0 and fixed openCameraDeviceAsync Impls (#193) * fix: Bumped eocv to 1.5.0 and fixed breaking changes * fix: Changed the vision release version to 2.0.0 * fix: Better error handling of camera opening * fix: Surrounded the callback with the lock * fix: issues with reset in RevIMU (#195) * fix: issues with ramsete controller ending before command runs (#194) * Min and Max flipped. Clarify AngleUnit type in parameter name (#201) min and max arguments flipped on call to constructor. Consider renaming parameter to minDegree and maxDegree to clarify to caller that AngleUnit.DEGREES is assumed. * Introduce Rate Feature to Motor Encoders (#196) * feat: clean up motor group inversion and add encoder rate * fix: typo in javadoc comment * fix: set last state before current state (#204) * Capstone Vision for 2021 Season (#200) * Added capstone detector and pipeline * Updated values on lines 119 and 117 of Capstone Detector * Added setters to tune area of detection * Released hierarchy Mat and now gives definition of contour * Released all matrices and fully tested pipeline Should be ready for release * Vector2d Normalization (#205) * fix: updated issue templates (#203) * feat: modify README and dependencies for v2.0 release (#206) Co-authored-by: Purav Datta <[email protected]> Co-authored-by: dansman805 <[email protected]> Co-authored-by: Lunerwalker2 <[email protected]> Co-authored-by: Kevin Sheck <[email protected]> Co-authored-by: Dolphin2Point1 <[email protected]> Co-authored-by: Ethan Leitner <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix
isFinishedError inRamseteCommandPlease note that we accept pull requests from anyone, but that does not mean it will be merged.
What kind of change does this PR introduce?
end(interrupted)stateDid this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Please make sure your PR satisfies the requirements of the contributing page