Skip to content

Add TrapezoidProfileCommmand and RepeatCommand#222

Merged
JIceberg merged 7 commits intoFTCLib:devfrom
Lunerwalker2:master
Jan 11, 2023
Merged

Add TrapezoidProfileCommmand and RepeatCommand#222
JIceberg merged 7 commits intoFTCLib:devfrom
Lunerwalker2:master

Conversation

@Lunerwalker2
Copy link
Copy Markdown
Contributor

Pull Requests

Please note that we accept pull requests from anyone, but that does not mean it will be merged.

What kind of change does this PR introduce?

  • Feature
    Ports the RepeatCommand and TrapezoidProfileCommand from WPILib.

Lacking an equivalent Timer class, the ElapsedTime FTC SDK class is used instead for the TrapezoidProfileCommand.

Did this PR introduce a breaking change?

A breaking change includes anything that breaks backwards compatibility either at compile or run time.
No

Please make sure your PR satisfies the requirements of the contributing page

@JIceberg JIceberg marked this pull request as ready for review January 9, 2023 19:58
@JIceberg
Copy link
Copy Markdown
Member

JIceberg commented Jan 9, 2023

Please merge the current version of dev into your branch.

@Lunerwalker2
Copy link
Copy Markdown
Contributor Author

It has been merged.

@JIceberg JIceberg merged commit c1019f4 into FTCLib:dev Jan 11, 2023
@JIceberg JIceberg mentioned this pull request Feb 22, 2023
JIceberg added a commit that referenced this pull request Feb 22, 2023
* Add TrapezoidProfileCommmand and RepeatCommand (#222)

* fix: Bumped eocv to 1.5.0 and fixed breaking changes

* fix: Changed the vision release version to 2.0.0

* fix: Better error handling of camera opening

* fix: Surrounded the callback with the lock

* feat: repeat and trapezoid profile command

- Added RepeatCommand
- Added TrapezoidProfileCommand

* Add TriggerReader Threshold (#230)

* Add TriggerReader Threshold

* Style update

* Removed redundant constructor

* Add Hard Encoder Reset (#234)

* AprilTag Feature Support (#236)

* Create AprilTag2dPipeline.java

* Update AprilTag2dPipeline.java

* Update build.gradle

* Fix outdated class name causing build fail

* Pipeline style update

* Added AprilTagDetector.java

* Added getDetection function

* Added getDetection function

* Removed unnecessary lines

* Added detector sample/example

* Added close() + customizable parameters (WIDTH, HEIGHT, ORIENTATION, GPU_ENABLED)

* Added JavaDocs + extra safety measures

* Fixed errors when initializing detector. Ready to be merged (excluding the 2D square)

* JavaDoc update (small)

* Fix atTarget in SensorDistanceEx (#237)

* Fix getName in CommandBase (#238)

* feat: changes for new version

---------

Co-authored-by: Lunerwalker2 <[email protected]>
Co-authored-by: Powercube7 <[email protected]>
@JIceberg JIceberg mentioned this pull request Feb 22, 2023
JIceberg added a commit that referenced this pull request Feb 22, 2023
* Add TrapezoidProfileCommmand and RepeatCommand (#222)

* fix: Bumped eocv to 1.5.0 and fixed breaking changes

* fix: Changed the vision release version to 2.0.0

* fix: Better error handling of camera opening

* fix: Surrounded the callback with the lock

* feat: repeat and trapezoid profile command

- Added RepeatCommand
- Added TrapezoidProfileCommand

* Add TriggerReader Threshold (#230)

* Add TriggerReader Threshold

* Style update

* Removed redundant constructor

* Add Hard Encoder Reset (#234)

* AprilTag Feature Support (#236)

* Create AprilTag2dPipeline.java

* Update AprilTag2dPipeline.java

* Update build.gradle

* Fix outdated class name causing build fail

* Pipeline style update

* Added AprilTagDetector.java

* Added getDetection function

* Added getDetection function

* Removed unnecessary lines

* Added detector sample/example

* Added close() + customizable parameters (WIDTH, HEIGHT, ORIENTATION, GPU_ENABLED)

* Added JavaDocs + extra safety measures

* Fixed errors when initializing detector. Ready to be merged (excluding the 2D square)

* JavaDoc update (small)

* Fix atTarget in SensorDistanceEx (#237)

* Fix getName in CommandBase (#238)

* feat: changes for new version

---------

Co-authored-by: Lunerwalker2 <[email protected]>
Co-authored-by: Powercube7 <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants