Conversation
Merged
JIceberg
added a commit
that referenced
this pull request
Feb 22, 2023
* Add TrapezoidProfileCommmand and RepeatCommand (#222) * fix: Bumped eocv to 1.5.0 and fixed breaking changes * fix: Changed the vision release version to 2.0.0 * fix: Better error handling of camera opening * fix: Surrounded the callback with the lock * feat: repeat and trapezoid profile command - Added RepeatCommand - Added TrapezoidProfileCommand * Add TriggerReader Threshold (#230) * Add TriggerReader Threshold * Style update * Removed redundant constructor * Add Hard Encoder Reset (#234) * AprilTag Feature Support (#236) * Create AprilTag2dPipeline.java * Update AprilTag2dPipeline.java * Update build.gradle * Fix outdated class name causing build fail * Pipeline style update * Added AprilTagDetector.java * Added getDetection function * Added getDetection function * Removed unnecessary lines * Added detector sample/example * Added close() + customizable parameters (WIDTH, HEIGHT, ORIENTATION, GPU_ENABLED) * Added JavaDocs + extra safety measures * Fixed errors when initializing detector. Ready to be merged (excluding the 2D square) * JavaDoc update (small) * Fix atTarget in SensorDistanceEx (#237) * Fix getName in CommandBase (#238) * feat: changes for new version --------- Co-authored-by: Lunerwalker2 <[email protected]> Co-authored-by: Powercube7 <[email protected]>
Merged
JIceberg
added a commit
that referenced
this pull request
Feb 22, 2023
* Add TrapezoidProfileCommmand and RepeatCommand (#222) * fix: Bumped eocv to 1.5.0 and fixed breaking changes * fix: Changed the vision release version to 2.0.0 * fix: Better error handling of camera opening * fix: Surrounded the callback with the lock * feat: repeat and trapezoid profile command - Added RepeatCommand - Added TrapezoidProfileCommand * Add TriggerReader Threshold (#230) * Add TriggerReader Threshold * Style update * Removed redundant constructor * Add Hard Encoder Reset (#234) * AprilTag Feature Support (#236) * Create AprilTag2dPipeline.java * Update AprilTag2dPipeline.java * Update build.gradle * Fix outdated class name causing build fail * Pipeline style update * Added AprilTagDetector.java * Added getDetection function * Added getDetection function * Removed unnecessary lines * Added detector sample/example * Added close() + customizable parameters (WIDTH, HEIGHT, ORIENTATION, GPU_ENABLED) * Added JavaDocs + extra safety measures * Fixed errors when initializing detector. Ready to be merged (excluding the 2D square) * JavaDoc update (small) * Fix atTarget in SensorDistanceEx (#237) * Fix getName in CommandBase (#238) * feat: changes for new version --------- Co-authored-by: Lunerwalker2 <[email protected]> Co-authored-by: Powercube7 <[email protected]>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add Hard Encoder Reset
Please note that we accept pull requests from anyone, but that does not mean it will be merged.
What kind of change does this PR introduce?
The current motor wrapper doesn't allow for a hard reset of the hardware position, which can lead to potential problems and as of now the only solution is to call to the available DcMotor and perform a STOP_AND_RESET. This should be an existing feature instead.
Did this PR introduce a breaking change?
A breaking change includes anything that breaks backwards compatibility either at compile or run time.
Please make sure your PR satisfies the requirements of the contributing page