Fixes developer config creation task#603
Closed
SourceNode wants to merge 28 commits intomapbox:masterfrom
Closed
Conversation
* Add roundaboutExits param to MapboxDirections Added roundaboutExits param to MapboxDirections. Still need to add fixtures, test and check param description * address PR review comments * add test fixture * add test * fix fixture generation * remove unused import * add constants to reflect two new types * fix line length
* omit originalRequestIdentifier, requestIdentifier and audioType optional fields over sending nulls * add support for null json literals
* added missing events * added starttime
* Add sdkIdentifier + sdkversion - add parameters to initialization call - add fields to MapboxEvent - set sdkIdentifier and sdkVersion when pushing turnstile event - write fallback method to preserve backwards compatability with previous versions
* fix version name to release 2.2.5 * change version name back to 2.3.0-SNAPSHOT * updated changelog for 2.2.4 and 2.2.5
* [WIP] make location provider optional * [WIP] fix location engine provider providing only those that are available * fix location engine provider public api and remove classes not necessary anymore * fix location engine provider public APIs * bump dependencies (build tools, support libraries, mapbox and lost) and address PR comments * ignore location engine coming from mapbox-android-sdk momentarily so that CI passes (chicken-egg problem) * fix naming * fix some breaking API changes * fix obtain best location engine not returning default location engine in some cases
…cation engine was already connected (mapbox#587)
- allow system to handle null variables and pass along null json objects when they are found
- make sure getStepMetadata is return json object for the step field within event
* make lost dependency provided * reverted back to lost 1.1
* reverted lost to 1.1 * restored circle script to build from master * removed deprecated tag
* [android] [auto] Update properties to version 2.2.6 in preparation for build. * temporarily edit circle script for release * revert 2.2.6 changes * updated changelog
- add in a null check for batteryStatus - takes care of bug associated with phones that don't report battery status
- change flushEventsQueueImmediately to public
- switch volume return from system volume to the music volume
Author
|
What is the next step here? |
|
Hey @SourceNode, sorry for the large delay on this one. We have actually gotten rid of the Android testapp inside this repo and switched to using a samples module which demonstrates how to use some of the APIs. For this, I have the access token being stored inside a BuildConfig file and use it when needed. See #688. Thanks for the contribution, sorry we couldn't get this merged. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #451