Skip to content

Fixes developer config creation task#603

Closed
SourceNode wants to merge 28 commits intomapbox:masterfrom
SourceNode:master
Closed

Fixes developer config creation task#603
SourceNode wants to merge 28 commits intomapbox:masterfrom
SourceNode:master

Conversation

@SourceNode
Copy link
Copy Markdown

@SourceNode SourceNode commented Oct 14, 2017

Fixes #451

1ec5 and others added 26 commits September 14, 2017 01:54
* Add roundaboutExits param to MapboxDirections

Added roundaboutExits param to MapboxDirections.

Still need to add fixtures, test and check param description

* address PR review comments

* add test fixture

* add test

* fix fixture generation

* remove unused import

* add constants to reflect two new types

* fix line length
* omit originalRequestIdentifier, requestIdentifier and audioType optional fields over sending nulls

* add support for null json literals
* added missing events

* added starttime
* Add sdkIdentifier + sdkversion

- add parameters to initialization call
- add fields to MapboxEvent
- set sdkIdentifier and sdkVersion when pushing turnstile event
- write fallback method to preserve backwards compatability with previous versions
* fix version name to release 2.2.5

* change version name back to 2.3.0-SNAPSHOT

* updated changelog for 2.2.4 and 2.2.5
* [WIP] make location provider optional

* [WIP] fix location engine provider providing only those that are available

* fix location engine provider public api and remove classes not necessary anymore

* fix location engine provider public APIs

* bump dependencies (build tools, support libraries, mapbox and lost) and address PR comments

* ignore location engine coming from mapbox-android-sdk momentarily so that CI passes (chicken-egg problem)

* fix naming

* fix some breaking API changes

* fix obtain best location engine not returning default location engine in some cases
- allow system to handle null variables and pass along null json objects when they are found
- make sure getStepMetadata is return json object for the step field within event
* make lost dependency provided

* reverted back to lost 1.1
* reverted lost to 1.1

* restored circle script to build from master

* removed deprecated tag
* [android] [auto] Update properties to version 2.2.6 in preparation for build.

* temporarily edit circle script for release

* revert 2.2.6 changes

* updated changelog
- add in a null check for batteryStatus
- takes care of bug associated with phones that don't report battery status
- change flushEventsQueueImmediately to public
- switch volume return from system volume to the music volume
@SourceNode SourceNode changed the title Fixes https://github.com/mapbox/mapbox-java/issues/451 Fixes developer config creation task Oct 14, 2017
@SourceNode
Copy link
Copy Markdown
Author

What is the next step here?

@zugaldia zugaldia requested a review from cammace October 16, 2017 15:41
@cammace
Copy link
Copy Markdown

cammace commented Dec 11, 2017

Hey @SourceNode, sorry for the large delay on this one. We have actually gotten rid of the Android testapp inside this repo and switched to using a samples module which demonstrates how to use some of the APIs. For this, I have the access token being stored inside a BuildConfig file and use it when needed. See #688.

Thanks for the contribution, sorry we couldn't get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants